Feature/5 커뮤니티 게시글 생성 기능 #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- imageUrl 있는 경우 / 없는 경우 나눠서 작성
…project/WEB1_1_Bongdari_BE into feature/5-create-community-board
- command 디렉토리 추가 - IntergrationTestSupport 상속 및 tearDown 추가
Closed
6 tasks
7zrv
reviewed
Nov 21, 2024
src/test/java/com/somemore/community/service/CreateCommunityServiceTest.java
Outdated
Show resolved
Hide resolved
leebs0521
reviewed
Nov 21, 2024
leebs0521
reviewed
Nov 21, 2024
src/main/java/com/somemore/community/service/command/command/CreateCommunityBoardService.java
Show resolved
Hide resolved
leebs0521
reviewed
Nov 21, 2024
src/main/java/com/somemore/community/service/command/command/CreateCommunityBoardService.java
Show resolved
Hide resolved
leebs0521
reviewed
Nov 21, 2024
Collaborator
leebs0521
left a comment
leebs0521
left a comment
There was a problem hiding this comment.
고생하셨습니다!
몇 부분 코멘트 남긴 거 확인해주시면 감사하겠습니다. ㅎㅎ
m-a-king
reviewed
Nov 21, 2024
Collaborator
m-a-king
left a comment
m-a-king
left a comment
There was a problem hiding this comment.
아영 님, 수고하셨습니다! �
TDD 어떠셨나요?
src/main/java/com/somemore/community/service/command/command/CreateCommunityBoardService.java
Outdated
Show resolved
Hide resolved
- imgUrl nullable false 추가
leebs0521
approved these changes
Nov 21, 2024
Collaborator
Author
테스트 코드를 먼저하는 게 너무 어색해서 오래걸린 거 같은데,, 조금은 적응한 거 같기도 하고,, 그렇습니다 |
…project/WEB1_1_Bongdari_BE into feature/5-create-community-board # Conflicts: # src/main/java/com/somemore/domains/CommunityBoard.java
|
7zrv
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved :
📌 과제 설명
커뮤니티 게시글 생성 기능
👩💻 요구 사항과 구현 내용
✅ PR 포인트 & 궁금한 점